-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly prints the size of the chunk during the build statistic print #16734
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source map files (those that end in .map
) should be excluded from the total size.
Can you also update the commit message so that it starts with:
fix(@angular-devkit/build-angular):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactored the accumulation function and excluded .map files!
Can you squash the commits? |
Can you please also reference #16627 in the commit footer? Ex:
|
…chunk during the build statistic print. Fixes: angular#16627
@clydin First time squashing, hopefully everything went according to plan 👍 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commits allows the cli to correctly print the sum of the sizes of the assets of a given chunk instead of the size of the first emitted asset
Attached:
-Before.PNG: What was happening before the fix in my local environment
-After.PNG: What's happening after the fix, notice that now the size of the "main-client" is the actual sum of the sizes of main-client.js and initial.css
-webpack.config.js: As requested, my current webpack configuration. This problem happens when i'm using the MiniCssExtractPlugin to extract my initial.css together with the main client
Before.PNG
After.PNG