Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Feb 17, 2020

We now add non node_modules .d.ts as a dependency of the main chunk. This is important under Ivy, because NG metadata is now part of the declarations files ex:

export declare class FooComponent implements OnInit {
    constructor();
    ngOnInit(): void;
    static ɵfac: i0.ɵɵFactoryDef<FooComponent>;
    static ɵcmp: i0.ɵɵComponentDefWithMeta<FooComponent, "lib-foo", never, {}, {}, never>;
}

Previously such files were not being added as dependency and such files didn't get invalidated when changed.

Closes #16920 and closes #16921
Ref: TOOL-1323

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Feb 17, 2020
We now add non node_modules `.d.ts` as a dependency of the main chunk. This is important under Ivy, because NG metadata is now part of the declarations files ex:

```ts
export declare class FooComponent implements OnInit {
    constructor();
    ngOnInit(): void;
    static ɵfac: i0.ɵɵFactoryDef<FooComponent>;
    static ɵcmp: i0.ɵɵComponentDefWithMeta<FooComponent, "lib-foo", never, {}, {}, never>;
}
```

Previously such files were not being added as dependency and such files didn't get invalidated when changed.

Closes #16920 and closes #16921
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 17, 2020
@kyliau kyliau merged commit 9b7b2f0 into angular:master Feb 18, 2020
@alan-agius4 alan-agius4 deleted the dts-watch branch February 18, 2020 20:48
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

4 participants