Skip to content

fix(@ngtools/webpack): only use require.resolve as a fallback in NGCC processing #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020
Merged

fix(@ngtools/webpack): only use require.resolve as a fallback in NGCC processing #19399

merged 1 commit into from
Nov 16, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 16, 2020

fix(@ngtools/webpack): only use require.resolve as a fallback in NGCC processing

Use enhanced-resolve instead of require.resolve to ensure that we can use symlink path instead of real-path when resolving a linked module.

Closes #19395

@google-cla google-cla bot added the cla: yes label Nov 16, 2020
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 16, 2020
…CC processing

Use `enhanced-resolve` instead of `require.resolve` to ensure that we can use symlink path instead of real-path when resolving a linked module.

Closes #19395
@alan-agius4 alan-agius4 requested a review from clydin November 16, 2020 11:26
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@clydin clydin merged commit eb313f7 into angular:master Nov 16, 2020
@alan-agius4 alan-agius4 deleted the symbolic-link-realpath branch November 16, 2020 20:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to run "ng build | serve | test" twice to finish command without errors
2 participants