Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): disable output hashing when running dev-server #19423

Merged
merged 1 commit into from
Nov 20, 2020
Merged

fix(@angular-devkit/build-angular): disable output hashing when running dev-server #19423

merged 1 commit into from
Nov 20, 2020

Conversation

alan-agius4
Copy link
Collaborator

Using output hashing with the dev-server can cause memory leaks because the dev server does not know when to clean up the old files.

See: webpack/webpack-dev-server#377 (comment)

Closes #10411

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 18, 2020
@google-cla google-cla bot added the cla: yes label Nov 18, 2020
@alan-agius4 alan-agius4 requested a review from clydin November 18, 2020 13:15
@alan-agius4 alan-agius4 marked this pull request as draft November 18, 2020 13:52
@alan-agius4 alan-agius4 marked this pull request as ready for review November 18, 2020 14:08
@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin November 19, 2020 10:44
…ng dev-server

Using output hashing with the dev-server can cause memory leaks because the dev server does not know when to clean up the old files.

See: webpack/webpack-dev-server#377 (comment)

Closes #10411
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2020
@filipesilva filipesilva merged commit 0b06fd6 into angular:master Nov 20, 2020
@alan-agius4 alan-agius4 deleted the disable-output-hashing-devbuilds branch November 20, 2020 12:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng serve --prod Cannot use [chunkhash] or [contenthash]
3 participants