Revert "feat(@schematics/angular): create new projects with rxjs 7" #21872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7bdcd7d. As of `rxjs` version 7 (up to and including the current 7.3.1), only the ES5 variant of `rxjs` can be imported/required when bundling. ES2015 files are available but currently not resolvable via the `exports` field defined within the package. While the ES5 variant is functional, it can lead to larger application sizes due to the extra code from the ES5 down-leveling process. This unfortunately can also lead to performance regressions with newly created applications (or applications that transition to v7) both by being larger and needing to execute more (down-leveled) code at application runtime. As a result, Angular’s current recommendation is to use `rxjs` version 6 to prevent performance regressions within Angular applications. Once these issues have been resolved and the ES2015 code is available for use, the new project default can be updated to use version 7 but that change is limited to only major versions of Angular.
alan-agius4
approved these changes
Oct 6, 2021
|
Closing as the proposed upstream fix as been merged. |
clydin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7bdcd7d.
As of
rxjsversion 7 (up to and including the current 7.3.1), only the ES5 variant ofrxjscan be imported/required when bundling. ES2015 files are available but currently not resolvable via theexportsfield defined within the package. While the ES5 variant is functional, it can lead to larger application sizes due to the extra code from the ES5 down-leveling process. This unfortunately can also lead to performance regressions with newly created applications (or applications that transition to v7) both by being larger and needing to execute more (down-leveled) code at application runtime. As a result, Angular’s current recommendation is to userxjsversion 6 to prevent performance regressions within Angular applications. Once these issues have been resolved and the ES2015 code is available for use, the new project default can be updated to use version 7 but that change is limited to only major versions of Angular.One potential solution is the following PR: ReactiveX/rxjs#6614