-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): exclude @angular/localize@<10.0.0
from ng add pa…
#24152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage discovery `@angular/localize@<10.0.0` has no peer dependencies. This can cause `ng add` to pick these versions of the package if the newer versions. See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822 ``` Test Process error Error: Process exit error - "ng add @angular/localize --skip-confirmation": 1... STDOUT: STDERR: npm version 7.4.0 detected. When using npm 7 with the Angular CLI, npm version 7.5.6 or higher is recommended. - Determining package manager... ℹ Using package manager: npm - Searching for compatible package version... ✔ Found compatible package version: @angular/localize@10.0.0-next.7. - Loading package information from registry... ✔ Package information loaded. - Installing packages... ✔ Packages successfully installed. NOT SUPPORTED: keyword "id", use "$id" for schema ID ```
alan-agius4
added
target: rc
This PR is targeted for the next release-candidate
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Oct 27, 2022
clydin
reviewed
Oct 27, 2022
clydin
approved these changes
Oct 27, 2022
… add package discovery Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
alan-agius4
added
merge: squash commits
When the PR is merged, a squash and merge should be performed
action: merge
The PR is ready for merge by the caretaker
and removed
action: review
The PR is still awaiting reviews from at least one requested reviewer
labels
Oct 27, 2022
dgp1130
pushed a commit
that referenced
this pull request
Oct 27, 2022
#24152) * fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery `@angular/localize@<10.0.0` has no peer dependencies. This can cause `ng add` to pick these versions of the package if the newer versions. See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822 ``` Test Process error Error: Process exit error - "ng add @angular/localize --skip-confirmation": 1... STDOUT: STDERR: npm version 7.4.0 detected. When using npm 7 with the Angular CLI, npm version 7.5.6 or higher is recommended. - Determining package manager... ℹ Using package manager: npm - Searching for compatible package version... ✔ Found compatible package version: @angular/localize@10.0.0-next.7. - Loading package information from registry... ✔ Package information loaded. - Installing packages... ✔ Packages successfully installed. NOT SUPPORTED: keyword "id", use "$id" for schema ID ``` * fixup! fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> (cherry picked from commit 65a0983)
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Nov 17, 2022
angular#24152) * fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery `@angular/localize@<10.0.0` has no peer dependencies. This can cause `ng add` to pick these versions of the package if the newer versions. See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822 ``` Test Process error Error: Process exit error - "ng add @angular/localize --skip-confirmation": 1... STDOUT: STDERR: npm version 7.4.0 detected. When using npm 7 with the Angular CLI, npm version 7.5.6 or higher is recommended. - Determining package manager... ℹ Using package manager: npm - Searching for compatible package version... ✔ Found compatible package version: @angular/localize@10.0.0-next.7. - Loading package information from registry... ✔ Package information loaded. - Installing packages... ✔ Packages successfully installed. NOT SUPPORTED: keyword "id", use "$id" for schema ID ``` * fixup! fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> (cherry picked from commit 65a0983) (cherry picked from commit 35e5f42)
dgp1130
pushed a commit
that referenced
this pull request
Nov 17, 2022
#24152) * fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery `@angular/localize@<10.0.0` has no peer dependencies. This can cause `ng add` to pick these versions of the package if the newer versions. See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822 ``` Test Process error Error: Process exit error - "ng add @angular/localize --skip-confirmation": 1... STDOUT: STDERR: npm version 7.4.0 detected. When using npm 7 with the Angular CLI, npm version 7.5.6 or higher is recommended. - Determining package manager... ℹ Using package manager: npm - Searching for compatible package version... ✔ Found compatible package version: @angular/localize@10.0.0-next.7. - Loading package information from registry... ✔ Package information loaded. - Installing packages... ✔ Packages successfully installed. NOT SUPPORTED: keyword "id", use "$id" for schema ID ``` * fixup! fix(@angular/cli): exclude `@angular/localize@<10.0.0` from ng add package discovery Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> Co-authored-by: Charles <19598772+clydin@users.noreply.github.com> (cherry picked from commit 65a0983) (cherry picked from commit 35e5f42)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
merge: squash commits
When the PR is merged, a squash and merge should be performed
target: rc
This PR is targeted for the next release-candidate
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ckage discovery
@angular/localize@<10.0.0
has no peer dependencies. This can causeng add
to pick these versions of the package if the newer versions.See: https://app.circleci.com/pipelines/github/angular/angular-cli/27402/workflows/faa64532-541a-4bea-b599-3c53afe42019/jobs/364822