Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): show warning when a TS Config is not found during migrations #24265

Merged

Conversation

alan-agius4
Copy link
Collaborator

Prior to this change an error was shown when a non existing tsconfig was referenced in the angular.json. This causes the update to fail.

Closes #24264

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Nov 17, 2022
@alan-agius4 alan-agius4 requested a review from clydin November 17, 2022 13:42
…during migrations

Prior to this change an error was shown when a non existing tsconfig was referenced in the angular.json. This causes the update to fail.

Closes angular#24264
@alan-agius4 alan-agius4 changed the title fix(@schrematics/angular): show warning when a TS Config is not found during migrations fix(@schematics/angular): show warning when a TS Config is not found during migrations Nov 17, 2022
@alan-agius4 alan-agius4 force-pushed the warn-instead-error-tsconfig-not-found branch from e2a6c50 to c716490 Compare November 17, 2022 13:43
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 17, 2022
@dgp1130 dgp1130 merged commit 5a123a6 into angular:main Nov 18, 2022
@alan-agius4 alan-agius4 deleted the warn-instead-error-tsconfig-not-found branch November 18, 2022 06:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration failed: Path "tsconfig.server.json" does not exist.
3 participants