Skip to content

fix(@angular-devkit/core): handle number like strings in workspace writer #24543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

alan-agius4
Copy link
Collaborator

The workspace writer previously transformed number like strings to numbers which causes failures when a project is named using a number like name.

Closes #24541

@alan-agius4 alan-agius4 force-pushed the writer-numberic-project branch 2 times, most recently from cca2cb2 to d8ec0f8 Compare January 13, 2023 12:56
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 13, 2023
@alan-agius4 alan-agius4 requested a review from clydin January 13, 2023 13:11
@alan-agius4 alan-agius4 added the merge: squash commits When the PR is merged, a squash and merge should be performed label Jan 18, 2023
@alan-agius4 alan-agius4 force-pushed the writer-numberic-project branch from 8efecb4 to daf30ba Compare January 18, 2023 19:34
@alan-agius4 alan-agius4 removed the merge: squash commits When the PR is merged, a squash and merge should be performed label Jan 18, 2023
…iter

The workspace writer previously transformed number like strings to numbers which causes failures when a project is named using a number like name.

Closes angular#24541
@alan-agius4 alan-agius4 force-pushed the writer-numberic-project branch from daf30ba to e150b19 Compare January 18, 2023 19:49
@alan-agius4 alan-agius4 requested a review from clydin January 18, 2023 19:49
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 18, 2023
@angular-robot angular-robot bot merged commit f6f5d79 into angular:main Jan 19, 2023
@alan-agius4 alan-agius4 deleted the writer-numberic-project branch January 19, 2023 23:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Can not add property to parent of type object' when creating a project with numeric name
2 participants