fix(@angular-devkit/build-angular): error during critical CSS inlining for external stylesheets #25584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for external stylesheets These changes revert the performance improvement from angular@e88aea6 and add a test. The problem with the previous approach is that it assumes that a `link` tag processed by Critters will be preceded by a `style` tag that was inserted by Critters. This assumption might not necessarily be true if Critters is unable to resolve the content of the linked styles. Furthermore, I'm not sure if we need to optimize this code path to begin with, because it only does a shallow traversal of the `head` tag which is generally fast and is unlikely to have many direct descendants. Fixes angular#25419.
crisbeto
added
action: review
crisbeto
commented
Jul 26, 2023
| @@ -146,7 +146,15 @@ class CrittersExtended extends Critters { | |||
| this.conditionallyInsertCspLoadingScript(document, cspNonce); | |||
| } | |||
|
|
|||
| link.prev?.setAttribute('nonce', cspNonce); | |||
There was a problem hiding this comment.
We could've kept this and checked that link.prev.tagName === 'style' but that'll be incorrect for a markup like this:
<head>
<style></style>
<link rel="stylesheet" href="https://some/external/style.css">
</head>
clydin
approved these changes
Jul 26, 2023
crisbeto
added
action: merge
3 tasks
|
Hi @crisbeto , in what version this fix will be available? |
|
It should've been out in 16.1.6. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes revert the performance improvement from e88aea6 and add a test. The problem with the previous approach is that it assumes that a
linktag processed by Critters will be preceded by astyletag that was inserted by Critters. This assumption might not necessarily be true if Critters is unable to resolve the content of the linked styles. Furthermore, I'm not sure if we need to optimize this code path to begin with, because it only does a shallow traversal of theheadtag which is generally fast and is unlikely to have many direct descendants.Fixes #25419.