fix(@angular-devkit/build-angular): ensure empty optimized Sass stylesheets stay empty #26664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
action: review
1 task
alan-agius4
reviewed
Dec 13, 2023
...r_devkit/build_angular/src/builders/application/tests/behavior/component-stylesheets_spec.ts
Outdated
Show resolved
Hide resolved
|
Can you also add |
alan-agius4
added
action: cleanup
alan-agius4
approved these changes
Dec 13, 2023
clydin
force-pushed
the
esbuild/empty-optimized-sass
branch
from
c7ac3e2 to
e5f5a18
Compare
clydin
added
action: merge
alan-agius4
reviewed
Dec 13, 2023
...r_devkit/build_angular/src/builders/application/tests/behavior/component-stylesheets_spec.ts
Outdated
Show resolved
Hide resolved
…sheets stay empty When an optimized Sass stylesheet becomes an empty string the AOT Angular host adapter was previously treating this as a falsy value and using the original content of the stylesheet. Empty strings are now considered valid values and will be passed to the AOT compiler as such.
clydin
force-pushed
the
esbuild/empty-optimized-sass
branch
from
e5f5a18 to
3f276e2
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an optimized Sass stylesheet becomes an empty string the AOT Angular host adapter was previously treating this as a falsy value and using the original content of the stylesheet. Empty strings are now considered valid values and will be passed to the AOT compiler as such.
Closes: #26653