Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@angular-devkit/build-angular): emit external sourcemaps for component styles #26711

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 19, 2023

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes #24049 and closes #26676

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Dec 19, 2023
@alan-agius4 alan-agius4 force-pushed the sm-external-component branch from 835b579 to a8c4ba1 Compare December 19, 2023 10:25
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Dec 19, 2023
@alan-agius4 alan-agius4 force-pushed the sm-external-component branch 2 times, most recently from 692fb69 to 915032b Compare December 19, 2023 11:10
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 19, 2023
@alan-agius4 alan-agius4 requested a review from clydin December 19, 2023 11:32
@alan-agius4 alan-agius4 force-pushed the sm-external-component branch from 915032b to 1c9b3e4 Compare December 20, 2023 07:55
@alan-agius4 alan-agius4 requested a review from clydin December 20, 2023 07:55
@alan-agius4 alan-agius4 force-pushed the sm-external-component branch 2 times, most recently from 77ca9b2 to e406cb2 Compare December 20, 2023 09:57
…ponent styles

This commits, changes the behaviour in the esbuild based builders by emitting component sourcemaps in external files instead of inlining them.

Closes angular#24049 and closes angular#26676
@alan-agius4 alan-agius4 force-pushed the sm-external-component branch from e406cb2 to ec17701 Compare December 20, 2023 10:35
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 20, 2023
@alan-agius4 alan-agius4 merged commit 47a064b into angular:main Dec 20, 2023
32 checks passed
@alan-agius4 alan-agius4 deleted the sm-external-component branch December 20, 2023 18:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
2 participants