Skip to content

feat(@angular-devkit/build-angular): enhance Sass rebasing importer for resources URL defined in variables and handling of external paths #27456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Apr 11, 2024

This commit introduces enhancements to the Sass rebasing importer, enabling it to resolve resources whose paths are stored in variables or namespaced variables. Also this addresses an issue where URL paths in Sass and SCSS files, flagged as external, were incorrectly rebased, leading to resolution errors.

Closes #27445 and closes #27007

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 11, 2024
@alan-agius4 alan-agius4 force-pushed the scss-var-rebase branch 3 times, most recently from b254019 to daa6609 Compare April 11, 2024 15:10
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Apr 11, 2024
@alan-agius4 alan-agius4 changed the title feat(@angular-devkit/build-angular): enhance Sass rebasing importer for variable and namespace resource resolution feat(@angular-devkit/build-angular): enhance Sass rebasing importer for resources URL defined in variables Apr 11, 2024
@alan-agius4 alan-agius4 changed the title feat(@angular-devkit/build-angular): enhance Sass rebasing importer for resources URL defined in variables Sass rebaser improvements Apr 11, 2024
@alan-agius4 alan-agius4 changed the title Sass rebaser improvements Sass URL rebaser improvements Apr 11, 2024
@alan-agius4 alan-agius4 requested a review from clydin April 11, 2024 17:24
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 11, 2024
@alan-agius4 alan-agius4 marked this pull request as ready for review April 11, 2024 17:31
@clydin
Copy link
Member

clydin commented Apr 11, 2024

I think if you update the resolve call in the first commit (1576335#diff-9c5b4495153e90ce431014a888e42237c40e7be76a89ed2866a012615f578f39R61-R67) to adjust the resolveDir instead of the input path you should be able to remove the need for the second fix commit.

@alan-agius4 alan-agius4 changed the title Sass URL rebaser improvements feat(@angular-devkit/build-angular): enhance Sass rebasing importer for resources URL defined in variables and handling of external paths Apr 12, 2024
@alan-agius4
Copy link
Collaborator Author

I think if you update the resolve call in the first commit (1576335#diff-9c5b4495153e90ce431014a888e42237c40e7be76a89ed2866a012615f578f39R61-R67) to adjust the resolveDir instead of the input path you should be able to remove the need for the second fix commit.

Yeah, you are absolutely right!

…or resources URL defined in variables and handling of external paths

This commit introduces enhancements to the Sass rebasing importer, enabling it to resolve resources whose paths are stored in variables or namespaced variables. Also this addresses an issue where URL paths in Sass and SCSS files, flagged as external, were incorrectly rebased, leading to resolution errors.

Closes angular#27445 and closes angular#27007
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2024
@clydin clydin merged commit 83d1d23 into angular:main Apr 12, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset referenced with CSS variables not found using application-builder Path declared in SCSS variable is incorrectly resolved
2 participants