feat(@angular-devkit/build-angular): enhance Sass rebasing importer for resources URL defined in variables and handling of external paths #27456
+136
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
scss-var-rebase
branch
3 times, most recently
from
b254019 to
daa6609
Compare
alan-agius4
added
the
target: major
alan-agius4
changed the title
alan-agius4
force-pushed
the
scss-var-rebase
branch
from
daa6609 to
1576335
Compare
alan-agius4
changed the title
alan-agius4
added
the
action: review
alan-agius4
force-pushed
the
scss-var-rebase
branch
from
fde8ad9 to
5e81cbf
Compare
|
I think if you update the resolve call in the first commit (1576335#diff-9c5b4495153e90ce431014a888e42237c40e7be76a89ed2866a012615f578f39R61-R67) to adjust the resolveDir instead of the input path you should be able to remove the need for the second fix commit. |
alan-agius4
changed the title
alan-agius4
force-pushed
the
scss-var-rebase
branch
from
5e81cbf to
35e7187
Compare
Yeah, you are absolutely right! |
…or resources URL defined in variables and handling of external paths This commit introduces enhancements to the Sass rebasing importer, enabling it to resolve resources whose paths are stored in variables or namespaced variables. Also this addresses an issue where URL paths in Sass and SCSS files, flagged as external, were incorrectly rebased, leading to resolution errors. Closes angular#27445 and closes angular#27007
alan-agius4
force-pushed
the
scss-var-rebase
branch
from
35e7187 to
1b4b196
Compare
clydin
approved these changes
Apr 12, 2024
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces enhancements to the Sass rebasing importer, enabling it to resolve resources whose paths are stored in variables or namespaced variables. Also this addresses an issue where URL paths in Sass and SCSS files, flagged as external, were incorrectly rebased, leading to resolution errors.
Closes #27445 and closes #27007