Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/schematics): use web standard error check for Deno support #27570

Merged
merged 1 commit into from
May 2, 2024

Conversation

littledivy
Copy link
Contributor

This commit replaces non-standard e.code check for TextDecoder.decode to TypeError.

This matches with other uses of TextDecoder.decode in this codebase, eg:

Enables @angular/cli to run on Deno. Ref denoland/deno#22607

deno run -A npm:@angular/cli new test-app/

@clydin
Copy link
Member

clydin commented May 1, 2024

Thank you for the contribution.
Can you update the commit message with the fix(@angular-devkit/schematics): prefix to allow the lint check to pass?

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels May 2, 2024
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you forgot to put @ before angular in the commit message scope.

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label May 2, 2024
@littledivy
Copy link
Contributor Author

Oops, fixed

@littledivy littledivy changed the title fix(angular-devkit/schematics): use web standard error check for Deno support fix(@angular-devkit/schematics): use web standard error check for Deno support May 2, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels May 2, 2024
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@clydin clydin merged commit 41ee8ea into angular:main May 2, 2024
33 checks passed
@littledivy littledivy deleted the deno_support branch May 3, 2024 03:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants