-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@schematics/angular): add option to export component as default #28268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. I have a couple of minor suggestions.
The current commit message is unclear and does not accurately describe the feature.
Something like the following:
feat(@schematics/angular): add option to export component as default
Introduces option `--export-default` to control whether the generated component uses a default export instead of a named export.
Closes: #25023
Hi @alan-agius4, Thanks. |
@aparzi, it looks like you still have the initial commit which is invalid, can you please squash and remove it? thanks |
Introduces option `--export-default` to control whether the generated component uses a default export instead of a named export. Closes: angular#25023
@alan-agius4 I fixed the commits everything should be ok. Please recheck the changes as a last check but everything should be ok. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
added option for export class in default mode
Closes #25023
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #25023
What is the new behavior?
added option for export class in default mode. Example
ng g c foo --export-default=true
. This option will generate a component with default keyword: ... export default class ...Does this PR introduce a breaking change?