Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e tests for autoCsp #28701

Merged
merged 1 commit into from
Dec 12, 2024
Merged

test: e2e tests for autoCsp #28701

merged 1 commit into from
Dec 12, 2024

Conversation

aaronshim
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: E2E tests

What is the current behavior?

No e2e tests for #28663

Issue Number: N/A

What is the new behavior?

e2e tests for #28663

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor suggestions, hopefully @clydin can take a quick look once he's back just to make sure we're restricting the test to esbuild correctly.

tests/legacy-cli/e2e/tests/build/auto-csp.ts Outdated Show resolved Hide resolved
tests/legacy-cli/e2e/tests/build/auto-csp.ts Outdated Show resolved Hide resolved
tests/legacy-cli/e2e/tests/build/auto-csp.ts Outdated Show resolved Hide resolved
@dgp1130 dgp1130 requested a review from clydin October 24, 2024 00:35
@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Oct 24, 2024
@alan-agius4 alan-agius4 added this to the v19 Candidates milestone Oct 30, 2024
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 5, 2024
@jkrems jkrems removed this from the v19 Candidates milestone Nov 15, 2024
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wish we had a better mechanism for serving the built page and running the browser, but given the current state of our e2e infra I don't think we have a better option which doesn't pull on a lot of other complexity. Any concerns here @clydin?

@dgp1130 dgp1130 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 12, 2024
@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 12, 2024
@jkrems jkrems added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Dec 12, 2024
@jkrems
Copy link
Contributor

jkrems commented Dec 12, 2024

I assume target: patch or target: minor are both equally fine for this change?

@dgp1130
Copy link
Collaborator

dgp1130 commented Dec 12, 2024

Should be patch, this is released on 19.0.0.

@jkrems jkrems merged commit f6b8c5e into angular:main Dec 12, 2024
33 checks passed
@jkrems
Copy link
Contributor

jkrems commented Dec 12, 2024

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants