-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: e2e tests for autoCsp #28701
test: e2e tests for autoCsp #28701
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor suggestions, hopefully @clydin can take a quick look once he's back just to make sure we're restricting the test to esbuild correctly.
afb8d27
to
42160cf
Compare
42160cf
to
25e7dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I wish we had a better mechanism for serving the built page and running the browser, but given the current state of our e2e infra I don't think we have a better option which doesn't pull on a lot of other complexity. Any concerns here @clydin?
I assume |
Should be |
The changes were merged into the following branches: main, 19.0.x |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No e2e tests for #28663
Issue Number: N/A
What is the new behavior?
e2e tests for #28663
Does this PR introduce a breaking change?
Other information