fix(@angular/build): minimize reliance on esbuild inject to prevent code reordering
#28953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
inject-removal
branch
2 times, most recently
from
2c41d48 to
ed26df5
Compare
… code reordering
Resolved an issue where the use of `esbuild`'s `inject` feature caused incorrect reordering of class structures during bundling. This reordering affected extended classes, as illustrated below:
```js
class e extends Ur {
constructor(n, r, i) {
super(n, r, i);
}
ngOnDestroy() {
this.flush();
}
static ɵfac = function (r) {
return new (r || e)(pe(Xe), pe(Ti), pe(Di));
};
static ɵprov = oe({ token: e, factory: e.ɵfac });
}
var Ur = class {
// Class properties and methods omitted for brevity
};
```
By reducing the reliance on `inject`, we ensure that the ordering of class properties and methods remains consistent, preserving the expected behavior.
Closes angular#28941
alan-agius4
force-pushed
the
inject-removal
branch
from
ed26df5 to
8d235bd
Compare
clydin
approved these changes
Nov 25, 2024
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue where the use of
esbuild'sinjectfeature caused incorrect reordering of class structures during bundling. This reordering affected extended classes, as illustrated below:By reducing the reliance on
inject, we ensure that the ordering of class properties and methods remains consistent, preserving the expected behavior.Closes #28941