Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): ensure correct handling of index.output for SSR #29024

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

alan-agius4
Copy link
Collaborator

Previously, the index file was not being renamed correctly when using server-side rendering (SSR).

Closes: #29012

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 3, 2024
@alan-agius4 alan-agius4 requested a review from clydin December 3, 2024 07:32
@alan-agius4 alan-agius4 force-pushed the index-csr-output branch 2 times, most recently from 17ee61f to 51371f1 Compare December 3, 2024 08:13
Previously, the index file was not being renamed correctly when using server-side rendering (SSR).

Closes: angular#29012
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2024
@alan-agius4 alan-agius4 merged commit 97897b7 into angular:main Dec 3, 2024
31 checks passed
@alan-agius4 alan-agius4 deleted the index-csr-output branch December 3, 2024 14:10
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development and Production differs on entry '/'
2 participants