Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ensure passing build before rest of PR jobs #29208

Merged
merged 1 commit into from
Dec 23, 2024
Merged

ci: ensure passing build before rest of PR jobs #29208

merged 1 commit into from
Dec 23, 2024

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 21, 2024

No description provided.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 21, 2024
@clydin clydin requested a review from josephperrott December 23, 2024 14:22
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 23, 2024
josephperrott
josephperrott approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clydin clydin added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 23, 2024
@clydin clydin merged commit adae1e8 into angular:main Dec 23, 2024
34 checks passed
@clydin clydin deleted the ci/pr-ensure-build-success branch December 23, 2024 15:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clydin @josephperrott