fix(@angular/build): replace deprecation of i18n.baseHref with a warning
#29429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
changed the title
i18n.baseHrefi18n.baseHref
…rning In certain scenarios, users build applications with the same `baseHref` when using i18n, primarily for deploying localized applications across multiple domains. To address this, we are removing the deprecation of `i18n.baseHref` and will revisit potential options as part of angular#29111 Instead of deprecating `i18n.baseHref`, we now issue a warning when it is used with SSR, as this may lead to undefined behavior. Closes angular#29396
alan-agius4
changed the title
i18n.baseHrefi18n.baseHref with a warning
alan-agius4
force-pushed
the
base-href-i18n
branch
from
7e0894d to
e57e644
Compare
alan-agius4
added
action: review
clydin
approved these changes
Jan 21, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.1.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios, users build applications with the same
baseHrefwhen using i18n, primarily for deploying localized applications across multiple domains. To address this, we are removing the deprecation ofi18n.baseHrefand will revisit potential options as part of #29111Instead of deprecating
i18n.baseHref, we now issue a warning when it is used with SSR, as this may lead to undefined behavior.Closes #29396