fix(@angular/build): update vite to version 5.4.14 #29472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
added
the
target: lts
clydin
force-pushed
the
vite-allowed-hosts-18.2.x
branch
from
f273866 to
fd8c847
Compare
Version update from 5.4.6 to address advisory GHSA-vg6x-rcgg-rjx6 Vite version 5.4.12+, which is now used by the Angular CLI with the `application`/`browser-esbuild` builders, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server via `localhost`, no changes should be needed. However, some development setups may now need to adjust the `allowedHosts` development server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here: https://vite.dev/config/server-options.html#server-allowedhosts The following is an example of the configuration option allowing `example.com`: ``` "serve": { "builder": "@angular-devkit/build-angular:dev-server", "options": { "allowedHosts": ["example.com"] }, ```
clydin
force-pushed
the
vite-allowed-hosts-18.2.x
branch
from
fd8c847 to
9849b94
Compare
alan-agius4
approved these changes
Jan 24, 2025
…wn error: Chrome failed to start: crashed` This fixes an issue where protractor integration tests are failing with ``` [07:38:37] I/direct - Using ChromeDriver directly... [07:38:39] E/launcher - unknown error: Chrome failed to start: crashed. (unknown error: DevToolsActivePort file doesn't exist) ``` (cherry picked from commit 0718e1b)
…der during `ng add` When using the `ng add` command, the package version selection logic was not correctly selected based on the available versions in desc order. This could lead to selecting an unintended version of the package. Closes: angular#28985 (cherry picked from commit 4ef45ec)
Temporary disable this test due to ``` Failed to launch local browser installed at /home/runner/.cache/bazel/_bazel_runner/f47b8283cc0f5922f9455b06771398a1/sandbox/processwrapper-sandbox/410/execroot/angular_cli/bazel-out/k8-fastbuild/bin/tests/legacy-cli/e2e.npm_node22.sh.runfiles/org_chromium_chromium_linux_x64/chrome-linux/chrome. This could be because of a mismatch between the version of puppeteer and Chrome or Chromium. Try updating either of them, or adjust the executablePath option to point to another browser installation. Use the --puppeteer flag to run tests with bundled compatible version of Chromium. dist/test-out/c48222bb-ca34-455e-bc1b-122521e1e71e/app.component.spec.js: ``` (cherry picked from commit 307eda1)
1 task
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version update from 5.4.6 to address advisory GHSA-vg6x-rcgg-rjx6
Vite version 5.4.12+, which is now used by the Angular CLI with the
application/browser-esbuildbuilders, contains a potentially breaking change for some development setups. Examples of such setups include those that use reverse proxies or custom host names during development. The change within a patch release was made by Vite to address a security vulnerability. For projects that directly access the development server vialocalhost, no changes should be needed. However, some development setups may now need to adjust theallowedHostsdevelopment server option. This option can include an array of host names that are allowed to communicate with the development server. The option sets the corresponding Vite option within the Angular CLI. For more information on the option and its specific behavior, please see the Vite documentation located here:https://vite.dev/config/server-options.html#server-allowedhosts
The following is an example of the configuration option allowing
example.com: