Skip to content

fix(@schematics/angular): generate directives without a .directive extension/type #29893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Mar 19, 2025

To align with the updated style guide, Angular v20 will generate services without a .directive file extension type for all directive related files by default. Projects will automatically use this naming convention. Projects can however opt-out by setting the type option to Directive for the directive schematic. This can be done as a default in the angular.json or directly on the commandline via --type=Directive when executing ng generate. As an example, example.directive.ts will now be named example.ts. Additionally, the TypeScript class name will be Example instead of the previous ExampleDirective.

@clydin clydin added the target: major This PR is targeted for the next major release label Mar 19, 2025
…tension/type

To align with the updated style guide, Angular v20 will generate services
without a `.directive` file extension type for all directive related
files by default. Projects will automatically use this naming convention.
Projects can however opt-out by setting the `type` option to `Directive`
for the directive schematic. This can be done as a default in the `angular.json`
or directly on the commandline via `--type=Directive` when executing `ng generate`.
As an example, `example.directive.ts` will now be named `example.ts`. Additionally,
the TypeScript class name will be `Example` instead of the previous `ExampleDirective`.
@clydin clydin force-pushed the style-guide/directive-empty-type branch from 965af89 to c2a1ad2 Compare March 19, 2025 18:27
@clydin clydin marked this pull request as ready for review March 19, 2025 18:30
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2025
@clydin clydin requested a review from alan-agius4 March 19, 2025 18:48
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 19, 2025
@clydin clydin merged commit 8d715fa into angular:main Mar 19, 2025
33 checks passed
@clydin clydin deleted the style-guide/directive-empty-type branch March 19, 2025 19:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants