Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@angular/build): provide a default for the application index option #29995

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 2, 2025

The application build system's index option is now considered optional. If not present, the value will be an index.html file within the configured project source root (sourceRoot). The default only applies to the short-form of the option. The object-based long-form continues to require explicit configuration of the input index HTML file. This change allows the removal of the index option from any project that uses the default generated value.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 2, 2025
@clydin clydin force-pushed the application/allow-default-index branch from 1d04742 to e114f5b Compare April 2, 2025 01:13
… option

The application build system's `index` option is now considered optional.
If not present, the value will be an `index.html` file within the configured
project source root (`sourceRoot`). The default only applies to the short-form
of the option. The object-based long-form continues to require explicit configuration
of the input index HTML file. This change allows the removal of the `index`
option from any project that uses the default generated value.
@clydin clydin force-pushed the application/allow-default-index branch from e114f5b to 2b26240 Compare April 2, 2025 01:46
@clydin clydin marked this pull request as ready for review April 2, 2025 01:46
@clydin clydin requested a review from alan-agius4 April 2, 2025 11:39
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 2, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 2, 2025
@clydin clydin merged commit 296873c into angular:main Apr 2, 2025
33 checks passed
@clydin clydin deleted the application/allow-default-index branch April 2, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants