Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): remove usage of __dirname from the config. #3422

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Dec 6, 2016

Fixes #3419

@@ -58,9 +58,12 @@ export function getWebpackCommonConfig(
devtool: sourcemap ? 'source-map' : false,
resolve: {
extensions: ['.ts', '.js'],
modules: [nodeModules]
modules: [nodeModules],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the project does not include trailing comma.

@hansl hansl merged commit 8597786 into angular:master Dec 6, 2016
@hansl hansl deleted the dirname branch December 6, 2016 18:35
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly resolve WebPack loaders within npm linked modules
4 participants