Skip to content

Make "app" point configurable in component generation #3878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Make "app" point configurable in component generation #3878

wants to merge 8 commits into from

Conversation

dhcdata
Copy link

@dhcdata dhcdata commented Jan 6, 2017

angular-cli.json allows flexibility for how project structure is defined. This PR allows for the "app" to be configurable. Consider the following tree structure:

├── .
├── angular-cli.json
├── src/ (default but configurable with "root" value)
│   ├── app/ (default)
│   ├── assets
│   ├── environments
│   ├── myCustomApp/ (configurable by added "app" value)
│   ├── index.html
│   ├── [...]
├── [...]

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 6, 2017
dhcdata added 2 commits January 6, 2017 03:30
Lint complained about line lengths?
@baruchvlz
Copy link
Contributor

baruchvlz commented Jan 7, 2017

You're trying to make src/app be src/{ngConfig.app[0].app} ?

@dhcdata
Copy link
Author

dhcdata commented Jan 7, 2017

Correct. This would make the "app" point configurable. When attempting to build a generic module in parallel with an specific application, this type of structure makes it easier to keep them separate.

@filipesilva
Copy link
Contributor

Superseded by #4610 I think.

@dopry
Copy link

dopry commented Feb 15, 2017

@filipesilva I do not think it is infact superceded by #4610, I think they're the similar and parts of a whole.

@dhcdata
Copy link
Author

dhcdata commented Feb 15, 2017

ng new command creates the project with src/app. Once that's done and #4610 is merged, identifying the "mount-ish" point is irrelevant.

Adding a flag for ng new might be beneficial but is outside the scope of where this PR went.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants