Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng): add warning when angular-cli is detected locally #4466

Closed
wants to merge 1 commit into from
Closed

feat(ng): add warning when angular-cli is detected locally #4466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/@angular/cli/bin/ng
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,30 @@ if (require('../package.json')['name'] == 'angular-cli'
`));
}

const packageJsonProjectPath = path.join(process.cwd(), 'package.json')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We allow people to run anywhere inside a project. You should use the __dirname instead (and potentially findup).

if (fs.existsSync(packageJsonProjectPath)) {
const packageJsonProject = require(packageJsonProjectPath);
const hasOldDep = !!packageJsonProject.dependencies['angular-cli'];
const hasOldDevDep = !!packageJsonProject.devDependencies['angular-cli'];
const hasDevDep = !!packageJsonProject.devDependencies['@angular/cli'];

if (hasOldDep || hasOldDevDep || !hasDevDep) {
const warnings = [
'The package "angular-cli" has been renamed to "@angular/cli". The old package will be deprecated soon.',
'Please take the following steps to avoid issues:'
];
if (hasOldDep) {
warnings.push('"npm uninstall --save angular-cli"');
}
if (hasOldDevDep) {
warnings.push('"npm uninstall --save-dev angular-cli"');
}
if (!hasDevDep) {
warnings.push('"npm install --save-dev @angular/cli@latest"');
}
process.stderr.write(yellow(warnings.join('\n\n'), '\n'));
}
}

resolve('@angular/cli', { basedir: process.cwd() },
function (error, projectLocalCli) {
Expand Down