Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): remove unneeded dependencies #4473

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Feb 7, 2017

No description provided.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 7, 2017
@@ -26,10 +26,6 @@
},
"homepage": "https://github.com/angular/angular-cli",
"dependencies": {
"@angular/compiler": "^2.3.1",
"@angular/compiler-cli": "^2.3.1",
"@angular/core": "^2.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're dropping @angular/core shouldn't you also drop the recently added rxjs dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hansl hansl force-pushed the deps branch 3 times, most recently from 2ac086b to 2995922 Compare February 7, 2017 03:24
@hansl hansl merged commit d8f36df into angular:master Feb 7, 2017
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@catull catull mentioned this pull request Feb 9, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 10, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 13, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Feb 13, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
filipesilva added a commit that referenced this pull request Feb 15, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert #4473
Fix #4575
@ahirhasmukh
Copy link

ahirhasmukh commented Feb 16, 2017

When I have tried to install npm install @angular/core@latest but it is doesn't update. Please give me solutions.


angular-cli-production@0.0.0 /var/www/html/loyalty-dapp
├── UNMET PEER DEPENDENCY @angular/core@2.4.7 invalid
├── UNMET PEER DEPENDENCY rxjs@5.0.0-beta.12
└── UNMET PEER DEPENDENCY zone.js@0.6.26

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules/chokidar/node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.0.17: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
npm WARN @angular/common@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/compiler@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/compiler-cli@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/core@2.4.7 requires a peer of rxjs@^5.0.1 but none was installed.
npm WARN @angular/core@2.4.7 requires a peer of zone.js@^0.7.2 but none was installed.
npm WARN @angular/forms@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/http@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/platform-browser@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/platform-browser-dynamic@2.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @angular/router@3.2.1 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN @ngtools/webpack@1.1.6 requires a peer of @angular/core@2.2.1 but none was installed.
npm WARN angular-in-memory-web-api@0.1.17 requires a peer of rxjs@5.0.0-rc.4 but none was installed.
npm WARN angular-in-memory-web-api@0.1.17 requires a peer of zone.js@^0.7.2 but none was installed.
npm WARN codelyzer@1.0.0-beta.4 requires a peer of @angular/core@~2.2.0 but none was installed.

asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
asnowwolf pushed a commit to asnowwolf/angular-cli that referenced this pull request Apr 12, 2017
We still need these dependencies as they are peerDeps of @ngtools/webpack.

Partially revert angular#4473
Fix angular#4575
@hansl hansl deleted the deps branch August 2, 2018 19:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants