-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@angular/cli): remove unneeded dependencies #4473
Conversation
CLAs look good, thanks! |
@@ -26,10 +26,6 @@ | |||
}, | |||
"homepage": "https://github.com/angular/angular-cli", | |||
"dependencies": { | |||
"@angular/compiler": "^2.3.1", | |||
"@angular/compiler-cli": "^2.3.1", | |||
"@angular/core": "^2.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're dropping @angular/core
shouldn't you also drop the recently added rxjs
dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
2ac086b
to
2995922
Compare
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
When I have tried to install
|
We still need these dependencies as they are peerDeps of @ngtools/webpack. Partially revert angular#4473 Fix angular#4575
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.