Skip to content

fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias #4973

wants to merge 0 commits into from

Conversation

chrisfitz
Copy link
Contributor

@chrisfitz chrisfitz commented Feb 24, 2017

This is a follow up to #3443 that didn't quite fix #3441.

This simplifies the plugin by sending the request path to ts.nodeModuleNameResolver and lets Typescript figure out its true path rather than looping through all the path options manually like it was previously doing.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@chrisfitz
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@chrisfitz chrisfitz changed the title fix(@angular/webpack): fix paths-plugin to allow '*' as alias fix(@angular-cli/webpack): fix paths-plugin to allow '*' as alias Feb 24, 2017
@chrisfitz chrisfitz changed the title fix(@angular-cli/webpack): fix paths-plugin to allow '*' as alias fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias Feb 24, 2017
Copy link
Contributor

@Meligy Meligy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write a test for this?

@chrisfitz chrisfitz closed this Feb 27, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngtools/webpack fails when using "*" as tsconfig paths alias
3 participants