fix(tsconfig): use inheritance for ng4 #5111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Feb 28, 2017
| "compilerOptions": { | ||
| "sourceMap": true, | ||
| "declaration": false, | ||
| "moduleResolution": "node", | ||
| "emitDecoratorMetadata": true, | ||
| "experimentalDecorators": true, | ||
| "target": "es5", |
There was a problem hiding this comment.
This is still needed on non-ng4 projects.
There was a problem hiding this comment.
I agree, that's why it is in the else part. Am I missing something?
There was a problem hiding this comment.
My bad, I misread this. Thanks!
cexbrayat
force-pushed
the
fix/tsconfig-inheritance
branch
from
64ce6fd to
67da010
Compare
filipesilva
approved these changes
Mar 1, 2017
filipesilva
pushed a commit
that referenced
this pull request
Mar 3, 2017
asnowwolf
pushed a commit
to asnowwolf/angular-cli
that referenced
this pull request
Apr 12, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #5060 added the dom library and es5 target to the base tsconfig, it can be removed in other ones.