Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): Fixing aliases for blueprint help #5342

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

sumitarora
Copy link
Contributor

Fixes: #5289

@@ -61,7 +61,8 @@ const aliasMap: { [alias: string]: string } = {
'm': 'module',
'p': 'pipe',
'r': 'route',
's': 'service'
's': 'service',
'g': 'guard'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think g is an alias for guard. didnt work for me, at least

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referenced this one: #5339

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it in PR #5339

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. so it will exist in RC 2 :)

@sumitarora sumitarora force-pushed the fix-blueprint-aliases branch from a09aa49 to 91e8a8a Compare March 13, 2017 14:11
@sumitarora sumitarora force-pushed the fix-blueprint-aliases branch from 91e8a8a to 1682b2c Compare March 13, 2017 14:55
@hansl hansl merged commit b6cc79c into angular:master Mar 13, 2017
@sumitarora sumitarora deleted the fix-blueprint-aliases branch March 24, 2017 16:35
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Aliases for blueprints are not shown in help
6 participants