-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: add module.id removal to moving doc #5365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLI projects don't need it, and soon Quickstart projects won't need it either so we might as well remove it.
Why won't the quickstart need it? The intention , I had thought, was to have 2 quickstarts:
The latter will need the My concern is that there is a lot of code out there that has module.id now, due to SystemJS. I think it's best if we continue to show both techniques, even though we clearly have chosen WebPack as the answer. Thoughts? |
@johnpapa: @Foxandxss is working on a SystemJS plugin that does away with the need for It is true that there is a lot of code out there that uses it, but the changes in this PR (to the moving in guide) would help in that, and thus we would be phasing out module.id in general. |
Perhaps and I say perhaps I would change the wording for something like "you may have", because we expect no one to have moduleId soon. |
It would be nice to have a way for folks to add that plugin, even if they didnt use the CLI. Since we have promoted this module.id technique for well over a year (for those not in the CLI), I can see value in having a short instruction on how to add this new plugin for SystemJS that would eliminate the need for it. |
Well, the plugin is specifically for those not using the CLI but only raw system.js. Perhaps we could release it out on npm so we can tell people to npm install it and how to add it to the systemjs.config.js. |
I think it would be helpful to many. There is a lot, and I mean a lot, of code with module.id today. I think writing this up no how to remove it and add this plugin (easy for them( OR go to the CLI (better for us, but may feel like more work) is good. This gives folks 2 valid options. Just to shed some light on why I feel so strongly that we need to help folks ... I have bene asked about module.id and why it broke over 50 times already in comments, email, tweets, and in person. And for every person who asks , I bet there are dozens who don't ask. So I just want to help them. |
I agree then. Let's keep it in the moving in steps but not remove the typings file. Maybe we'll remove it later, or for 2.0, but we leave it in for now to easy in folks. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
CLI projects don't need it, and soon Quickstart projects won't need it either so we might as well remove it.