fix(@angular/cli): all styleUrls and templateUrl are relative #5442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a follow up of #3842 which should have fixed it but still relied on web pack's resolution. |
filipesilva
suggested changes
Mar 15, 2017
| // if string, assume relative path unless it start with / | ||
| return `'${loaderUtils.urlToRequest((element as ts.StringLiteral).text, '')}'`; | ||
| const url = (element as ts.StringLiteral).text; | ||
| if (url[0] == '.') { |
There was a problem hiding this comment.
Would be better to check for ./, since it is valid to have a filename starting with ..
There was a problem hiding this comment.
Good point!
That'd be a check for ./ or ../ then
filipesilva
approved these changes
Mar 17, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5056.