Various Fixes with Modules #5510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Mar 19, 2017
| @@ -11,16 +11,49 @@ describe('@ngtools/webpack', () => { | |||
| host.writeFile('/file.ts', ` | |||
| export const obj = { moduleId: 123 }; | |||
| export const obj2 = { moduleId: 123, otherValue: 1 }; | |||
| export const obj2 = { otherValue: 1, moduleId: 123 }; | |||
| export const obj3 = { otherValue: 1, moduleId: 123 }; | |||
There was a problem hiding this comment.
You added obj3 but don't check it on the tests. Is that intentional?
There was a problem hiding this comment.
Fixed the check to not use the variable name.
Prior to this we were removing all mentions of moduleId, which is invalid if the users want to use it themselves. Now we only removes it if its in a decorator. There might be a slight regression with people using static const objects instead of object literals in their decorators but this shuold not happen often and even less often with moduleId. Fixes angular#5509.
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set. The issue happened because people are using "files": ["main.ts"] or something similar, and when we load another file than main we dont set the parent nodes. Fixes angular#5143 Fixes angular#4817
filipesilva
approved these changes
Mar 20, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(@ngtools/webpack): only remove moduleId in decorators …
Prior to this we were removing all mentions of moduleId, which is invalid if the users want to use it themselves. Now we only removes it if its in a decorator. There might be a slight regression with people using static const objects instead of object literals in their decorators but this shuold not happen often and even less often with moduleId.
Fixes #5509.
fix(@ngtools/webpack): add parent nodes and keep program …
Technically that program should always be the valid one, and is needed in some cases (e.g. diagnostics). Adding parent nodes get rid of the getChildAt error that happens, because the prop.parent is not set.
The issue happened because people are using "files": ["main.ts"] or something similar, and when we load
another file than main we dont set the parent nodes.
Fixes #5143
Fixes #4817