-
Notifications
You must be signed in to change notification settings - Fork 12k
feat(@angular/cli): adds --animation flag to ng new #5786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9803555
to
2c0c1a8
Compare
5b0f6c3
to
cd1ab1b
Compare
cd1ab1b
to
711965d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of supporting animations out of the box with the CLI.
I don't think the CLI should generate an use an animation though, so please remove app-fade-in.animation.ts
as well as references to it.
Also, BrowserAnimationsModule
should be used in place of BrowserModules
not in addition to in app.module.ts
Good catch to include updates to the documentation 👍
7da07d9
to
781fb95
Compare
Hey @Brocco ! Thanks for the feedback ~ ^^ Specially for the part about
I updated the PR with the changes requested and added an alias of Let me know if I missed anything or if there other requests ! :D |
781fb95
to
0411a0c
Compare
Hey again @Brocco! I added When I first tested it out using |
This PR is being superseded by #6144, which adds animations a lot of other changes. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #5785