Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protractor::getText now returns a Promise, so updated app.e2e-spec.ts. #6361

Closed
wants to merge 1 commit into from

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented May 18, 2017

https://github.com/angular/protractor/blob/master/CHANGELOG.md#breaking-changes-4

I think. Double check from one of you required. My IDE was complaining so I traced the error all the way down the pipeline.

@sumitarora sumitarora self-assigned this May 18, 2017
@sumitarora
Copy link
Contributor

@Brocco
Copy link
Contributor

Brocco commented May 24, 2017

This was merged into master reference: ba15605

@Brocco Brocco closed this May 24, 2017
@cexbrayat
Copy link
Member

cexbrayat commented May 24, 2017

To be honest, I don't understand this change. Protractor has returned promises for a very long time (the breaking change mentioned is from Protractor 2.0.0 !).

I think the problem encountered by @SamuelMarks is probably something like angular/protractor#4176. The cause is @types/jasmine 2.5.46. Try to pin your version to 2.5.45 and you should be fine?

Anyway I think this PR is introducing code that is not really the way Protractor should be used IMHO.

@cexbrayat
Copy link
Member

I think the proper fix to the problem encountered is something like #6799 :

  • use last @types/jasmine
  • add @types/jasminewd2
  • add jasminewd2 to the tsconfig for e2e tests

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants