Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix poll test on circleci #6959

Closed
wants to merge 1 commit into from
Closed

ci: fix poll test on circleci #6959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/e2e/tests/build/poll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,6 @@ import {expectToFail, wait} from '../../utils/utils';
const webpackGoodRegEx = /webpack: Compiled successfully./;

export default function() {

// @filipesilva: This test doesn't work correctly on CircleCI while being ran by the test script.
// Polling time seems to be ignored and several builds are fired per second.
// Debugging showed that webpack things the `src/` directory changed on each rebuild.
// Disabling for now.
if (process.env['CIRCLECI']) {
return;
}


return silentExecAndWaitForOutputToMatch('ng', ['serve', '--poll=10000'], webpackGoodRegEx)
// Wait before editing a file.
// Editing too soon seems to trigger a rebuild and throw polling out of whack.
Expand Down