Skip to content

feat(@angular/cli): rewrite stats output to properly show the asset size #6989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Jul 14, 2017

This is a feature in principle; the output is changed. The stats themselves dont though.

Fixes #3565.
Fixes #545.

This is a feature in principle; the output is changed. The stats themselves dont though.
@filipesilva
Copy link
Contributor

Before:

$ ng build --prod
Hash: f9ccec984bf2f8fff36a
Time: 9387ms
chunk    {0} polyfills.1c984d8776c90bb4d51a.bundle.js (polyfills) 177 kB {4} [initial] [rendered]
chunk    {1} main.d54d7fa36f923ae90143.bundle.js (main) 14.1 kB {3} [initial] [rendered]
chunk    {2} styles.d41d8cd98f00b204e980.bundle.css (styles) 69 bytes {4} [initial] [rendered]
chunk    {3} vendor.380182324a390cacc32a.bundle.js (vendor) 849 kB [initial] [rendered]
chunk    {4} inline.285982d2684a9ffa6794.bundle.js (inline) 0 bytes [entry] [rendered]

After

$ ng build --prod
Date: 2017-07-21T18:28:53.018Z
Hash: 2cb2a95245efc72e6741
Time: 9502ms
chunk {0} polyfills.1c984d8776c90bb4d51a.bundle.js (polyfills) 62.6 kB {4} [initial] [rendered]
chunk {1} main.d54d7fa36f923ae90143.bundle.js (main) 5 kB {3} [initial] [rendered]
chunk {2} styles.d41d8cd98f00b204e980.bundle.css (styles) 0 bytes {4} [initial] [rendered]
chunk {3} vendor.380182324a390cacc32a.bundle.js (vendor) 215 kB [initial] [rendered]
chunk {4} inline.285982d2684a9ffa6794.bundle.js (inline) 1.45 kB [entry] [rendered]

Main differences are the sizes shown and the timestamp.

@Brocco Brocco merged commit 61b4e22 into angular:master Jul 21, 2017
@celliott181
Copy link
Contributor

Wooooo! Glad #545 got fixed with this! Getting blocked by webpack was not ideal.

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
The new function already correctly prints warnings/errors.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit to filipesilva/angular-cli that referenced this pull request Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
filipesilva added a commit that referenced this pull request Jul 31, 2017
Errors and warnings neet to be printed separately.

Followup to #6989
Fix #7213
hansl pushed a commit that referenced this pull request Aug 3, 2017
Errors and warnings neet to be printed separately.

Followup to #6989
Fix #7213
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
Errors and warnings neet to be printed separately.

Followup to angular#6989
Fix angular#7213
@hansl hansl deleted the stats-size branch November 28, 2018 23:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants