feat(@angular/cli): make the common chunk optional

[kevinbuhmann]

• Add a "--no-common-chunk" build option for disabling the common async chunk.
• The existing behavior is maintained by default.

closes #7021

[kevinbuhmann]

I need guidance on testing this. The default project doesn't generate a common chunk, so I couldn't find anything to test against.

[filipesilva]

Heya @kevinphelps, thanks for taking this on. I can't promise it will go in as is (flag names, functionality), but for now it looks good and I will bring it up for discussion.

As for testing, you can look at https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/misc/common-async.ts for the existing test. Another similar test is https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/misc/lazy-module.ts. In both we generate lazy modules and then count output files. Everything is automatically cleaned up after the test is done.

[kevinbuhmann]

Thanks! I wasn't sure if the team would accept the --common-chunk-min-chunks option, but I added it in case. I think it makes it more flexible, but I understand that it might expose too much of the webpack config in the public api. But it would great the --common-chunk/--no-common-chunk option could be accepted so that apps could use the previous functionality. :)

I'll take a look those tests and add a test for this option.

[filipesilva]

Yeah I definitely understand the concern exposed in #7021, it's a big problem for bigger apps.

[filipesilva]

Can you remove the --common-chunk-min-chunks flag and add a test for --no-common-chunk in https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/misc/common-async.ts#L44-L51 please?

See #7021 (comment) for context.

[kevinbuhmann]

I have made the changes locally. I will update this PR once the full test suite completes.

[kevinbuhmann]

The tests passed in https://travis-ci.org/angular/angular-cli/jobs/255060001. I only changed the commit message. It looks like a rebuild is needed because Chrome timed out.

[filipesilva]

LGTM, thanks a lot for your work in adding this option 👍

[kevinbuhmann]

No problem!

[kevinbuhmann]

Thanks!

[bossysmile11]

On Wed, Jul 19, 2017 at 8:27 AM Kevin Phelps ***@***.***> wrote: Thanks! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#7023 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIBfe1-LJGk11RSKR-3eLBfze16GX9aLks5sPhJVgaJpZM4Oa2F7> .

-- Sent from Gmail Mobile

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}