Skip to content

feat(@angular/cli): add --preserve-symlinks to ng test #7598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2017

Conversation

filipesilva
Copy link
Contributor

Fix #7081

@hansl hansl merged commit b0fd35e into angular:master Sep 13, 2017
@filipesilva filipesilva deleted the allow-preserve-symlink-test branch September 13, 2017 20:10
@trho
Copy link

trho commented Sep 20, 2017

Can you please merge this into 1.4.X, too?
It was not included in the 1.4.2 release.

Our project uses FESM modules with ES2015 target version and the 1.5 beta results in
"Cannot convert undefined or null to object" errors.
This seems to be related to the following bug:
angular/angular#15127

See also jinder comment in this issue:
"This is going to become a larger issue as Angular CLI 1.5 beta has just shipped with ES6 target support. In JIT mode, this causes #15325. AOT seems to work fine, however."

Version 1.4.1 with this PR works fine, though.

@basst314
Copy link

Hi @filipesilva and @hansl ,
will this also be merged into the 1.4.x branch?
Would be awesome if we could use this without being forced to upgrade to angular 5 first.
Thanks!

@filipesilva
Copy link
Contributor Author

This will not be merged into 1.4.x because it is a new feature. We try to only add new features in new minor versions. You can still use 1.5 without updating to Angular 5 though. It still supports Angular 2/4.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserve-symlinks option not supported with ng test
5 participants