fix(@angular/cli): disable node global

[filipesilva]

The node only global object had been left in because it used to cause a build size regression with Angular.

This doesn't seem to be the case anymore so it should be removed because it causes problematic interactions with some libraries.

Fix #5804
Supersedes #7931

[filipesilva]

Note: webpack-dev-server@3.8.0 and up do not support old IE versions: https://github.com/webpack/webpack-dev-server#caveats

[Wykks]

Whoops I found an issue with these changes :
Uncaught ReferenceError: process is not defined
https://github.com/mapbox/mapbox-sdk-js/blob/f1012d33d5315866a66bf97d27d0dc0f66807161/vendor/invariant.js#L23
Only with ng serve, prod serve works fine.

[filipesilva]

Ok I see. It's quite common for libs to try and check the env if available so we shouldn't disable it.

Thanks a bunch for testing this, it would have gotten through otherwise.

[filipesilva]

@Wykks done, the PR doesn't remove process anymore.

[IgorMinar]

I confirmed that this helps quite a bit for aio. I'm not sure what all the implications are for other projects.

[IgorMinar]

heads up that this might break the old service worker library. see: angular/angular#19702 (comment) should we make this option configurable? or at least turn it on if the old service worker is present?

…

On Mon, Oct 23, 2017 at 2:57 PM Hans ***@***.***> wrote: Merged #8130 <#8130>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6KeQsmmPFnlPoo7g0jps2eLV1Xbsks5svQvmgaJpZM4QA4EL> .

[filipesilva]

@IgorMinar I think the error on the message you linked was due to patching the CLI files to disable global but not having updated webpack-dev-server with it (as this PR does). The webpack-dev-server version was needed to fix webpack/webpack-dev-server#1147 (fixed by webpack/webpack-dev-server#1148).

[hccampos]

Seems like pdfjs is broken due to this change. It (or one of its dependencies) tries to load the browserify Buffer, which checks the environment.

[vecernik]

can you make global configurable in angular-cli.json ? It also breaks Faye.

[IgorMinar]

I'm starting to think that this will have to be configurable to allow certain libraries to work, but it should be off by default.

…

On Fri, Oct 27, 2017 at 3:27 PM Michal Žeravík ***@***.***> wrote: can you make global configurable in angular-cli.json ? It also breaks Faye. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8130 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANM6J4x0OVZw9KAZ4q3mOuJEh6ewCv7ks5swdpLgaJpZM4QA4EL> .

[vecernik]

@IgorMinar I agree. I have found no way how to get Faye (and possibly others) to work without global.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}