Skip to content

fix(@ngtools/webpack): fix module detection with reexports #8197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2017
Merged

fix(@ngtools/webpack): fix module detection with reexports #8197

merged 1 commit into from
Oct 26, 2017

Conversation

filipesilva
Copy link
Contributor

Fix #7925

@filipesilva filipesilva requested a review from hansl October 26, 2017 16:45
hansl
hansl approved these changes Oct 26, 2017
View reviewed changes
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be problems in some edge cases in the future. We need to get rid of entryModule entirely at some point.

@hansl hansl merged commit 9f02eef into angular:master Oct 26, 2017
@filipesilva filipesilva deleted the fix-barrel-entry-ngmodule branch October 26, 2017 17:00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.5.0-beta.3] AOT build failed - Module not found (Can't resolve './app.ngfactory')
3 participants
@filipesilva @hansl @googlebot