fix(@angular/cli): remove postcss-custom-properties #8874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
suggested changes
Dec 14, 2017
| @@ -67,7 +66,7 @@ export function getStylesConfig(wco: WebpackConfigOptions) { | |||
| // If deployUrl contains a scheme, ignore baseHref use deployUrl as is. | |||
| return `${deployUrl.replace(/\/$/, '')}${url}`; | |||
| } else if (baseHref.match(/:\/\//)) { | |||
| // If baseHref contains a scheme, include it as is. | |||
| // If baseHref contains a scheme, include it as is.git | |||
There was a problem hiding this comment.
Urf durf, my bad
filipesilva
force-pushed
the
remove-custom-props
branch
from
5c6851e to
56d8efd
Compare
mgol
approved these changes
Dec 20, 2017
|
👏 |
Brocco
previously approved these changes
Jan 8, 2018
We currently use a fallback for CSS custom properties on older browsers. This approach has a few problems: - does not work if the custom property declaration is not part of the same of the same file that uses it (multiple global stylesheets, component css). - does not work at all for component CSS in AOT. @clydin suggested a browserlist based approach for enabling this functionality, but that requires a new feature that we don't have. Since currently taking advantage of the custom property fallback is flaky even in the best case scenario, and potentially broken in prod (AOT), I think it's better to remove it altogether until we can actually do it right. Fix angular#8289
filipesilva
force-pushed
the
remove-custom-props
branch
from
56d8efd to
8635d00
Compare
hansl
approved these changes
Jan 9, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use a fallback for CSS custom properties on older browsers. This approach has a few problems:
@clydin suggested a browserlist based approach for enabling this functionality, but that requires a new feature that we don't have.
Since currently taking advantage of the custom property fallback is flaky even in the best case scenario, and potentially broken in prod (AOT), I think it's better to remove it altogether until we can actually do it right.
Fix #8289