-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Fix a compilation error that occurs when the "paths" option is not set but "baseUrl" is #9673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
Thank you for the contribution. However, while this may fix the problem observed within the referenced issue, this will break module resolution in the general case. The |
@clydin what cases would cause this to break? This works on a new app generated from angular-cli and the app that wouldn't compile with v1.7.0. |
For a package, |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #9671