This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 100
fix: add ng update instruction to v16 #220
Open
Pascalmh
wants to merge
2
commits into
angular:main
Choose a base branch
from
Pascalmh:ng-update-v16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't the instruction go one line lower since the description of the next step mentions it should be checked before you update the application: |
@shonderdos good catch, thanks! Updated the PR. |
Why not merge the document content yet? |
Any reason this hasn't been merged yet? |
Still doc hasn't been updated! |
leifjones
approved these changes
Jun 7, 2023
@angular-cli Could this be completed for the benefit of users? |
// cc @mgechev |
Decided to create a new Pull Request to address this and the Material V16 note. I'll get the PR completed shortly after approval. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #219