Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Add a & href tags around Typescript 3.1 & 4.4 releases notes #232

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a & href tags around Typescript 3.1 & 4.4 releases notes #232

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46cb10f
add a & href tags around Typescript 3.1 & 4.4 releases notes
E-Jacques Jun 23, 2023
5c1d8c5
fix: Add missing 'target="_blank"' to a tags
E-Jacques Jun 23, 2023
e4f6600
fix: Add missing changes on node links
E-Jacques Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/recommendations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const RECOMMENDATIONS: Step[] = [
{ possibleIn: 600, necessaryAsOf: 700, level: ApplicationComplexity.Basic, step: 'update to RxJS 6', action: 'Remove deprecated RxJS 5 features using <a href="https://github.com/ReactiveX/rxjs-tslint" target="_blank">rxjs-tslint auto update rules</a><br/><br/>For most applications this will mean running the following two commands:<br/><br/>`npx rxjs-tslint`<br/>`rxjs-5-to-6-migrate -p src/tsconfig.app.json`'},
{ possibleIn: 600, necessaryAsOf: 800, level: ApplicationComplexity.Medium, step: 'remove rxjs-compat', action: 'Once you and all of your dependencies have updated to RxJS 6, remove `rxjs-compat`.'},
{ possibleIn: 610, necessaryAsOf: 800, level: ApplicationComplexity.Medium, step: 'use files instead of versionedFiles', action: 'If you use the Angular Service worker, migrate any `versionedFiles` to the `files` array. The behavior is the same.'},
{ possibleIn: 700, necessaryAsOf: 700, level: ApplicationComplexity.Basic, step: 'TypeScript 3.1', action: 'Angular now uses TypeScript 3.1, read more about any potential breaking changes: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-1.html', },
{ possibleIn: 700, necessaryAsOf: 700, level: ApplicationComplexity.Basic, step: 'TypeScript 3.1', action: 'Angular now uses TypeScript 3.1, read more about any potential breaking changes: <a href="https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-1.html" target="_blank">TypeScript 3.1 release notes</a>', },
{ possibleIn: 700, necessaryAsOf: 700, level: ApplicationComplexity.Basic, step: 'Node 10', action: 'Angular has now added support for Node 10: https://nodejs.org/en/blog/release/v10.0.0/', },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same for this link for Node as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, I've updated my PR.
Also, seems like external links are missing the associated icon (see below) that is needed for the links to be accessible. Shall I add them in this PR, create another PR or accessibility is not an issue for now?

main-qimg-c1584f882355c17aeadf6b0fc9e5e95f-lq

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to take this separately. Please create a new issue for this.

{ possibleIn: 700, necessaryAsOf: 700, level: ApplicationComplexity.Basic, windows: false, step: 'v7 update', action: 'Update to v7 of the core framework and CLI by running `NG_DISABLE_VERSION_CHECK=1 npx @angular/cli@7 update @angular/cli@7 @angular/core@7` in your terminal.'},
{ possibleIn: 700, necessaryAsOf: 700, level: ApplicationComplexity.Basic, windows: true, step: 'v7 update', action: 'Update to v7 of the core framework and CLI by running `cmd /C "set "NG_DISABLE_VERSION_CHECK=1" && npx @angular/cli@7 update @angular/cli@7 @angular/core@7"` in your terminal.'},
Expand Down Expand Up @@ -183,7 +183,7 @@ export const RECOMMENDATIONS: Step[] = [

{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Basic, step: 'v13 ng update', action: 'Run `ng update @angular/core@13 @angular/cli@13` which should bring you to version 13 of Angular.' },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Basic, material: true, step: 'update @angular/material', action: 'Run `ng update @angular/material@13`.' },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Basic, step: 'TypeScript 4.4', action: 'Angular now uses TypeScript 4.4, read more about any potential breaking changes: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html', },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Basic, step: 'TypeScript 4.4', action: 'Angular now uses TypeScript 4.4, read more about any potential breaking changes: <a href="https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-4.html" target="_blank">TypeScript 4.4 release notes</a>', },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Basic, step: 'v13 node', action: 'Make sure you are using <a href="http://www.hostingadvice.com/how-to/update-node-js-latest-version/" target="_blank">Node 12.20.0 or later</a>', },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Medium, step: 'v13 routerLink', action: 'You can now disable the navigation of a `routerLink` by passing `undefined` and `null`. Previously the `routerLink` directive used to accept these two values as equivalent to an empty string.' },
{ possibleIn: 1300, necessaryAsOf: 1300, level: ApplicationComplexity.Medium, step: 'v13 router loadChildren', action: 'You can no longer specify lazy-loaded routes by setting a string value to `loadChildren`. Make sure you move to dynamic ESM import statements.' },
Expand Down