This repository was archived by the owner on Dec 4, 2017. It is now read-only.
docs(hierarchical-di): Correct avoidance example (#3086) and more #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
changed the title
…ther tweaks closes angular#3086 sample reworked to conform to our sample style, to make more sense, and cover the examples discussed copy edits to bring closer to Google docs standards.
wardbell
force-pushed
the
docs-hdi-3086
branch
from
b6534c0 to
91e8c77
Compare
filipesilva
approved these changes
Jan 12, 2017
| 'edit button should be displayed'); | ||
| }); | ||
| describe('Heroes Scenario', () => { | ||
| let page = { |
There was a problem hiding this comment.
Interesting usage of the Page Objects pattern. There really is no reason to have it separately in smaller tests.
There was a problem hiding this comment.
My reason was that I was gathering together the queries I wanted to do in tests. Wasn't sure how many tests I would write but I was pretty sure the affordances should be involved.
Did it make the tests hard to read?
There was a problem hiding this comment.
Not at all, I think we should have more page objects like this in our e2e tests overall.
wardbell
force-pushed
the
docs-hdi-3086
branch
6 times, most recently
from
ffe5260 to
bc4d02e
Compare
wardbell
force-pushed
the
docs-hdi-3086
branch
from
bc4d02e to
4fa7bd0
Compare
abdel-ships-it
pushed a commit
to abdel-ships-it/angular.io
that referenced
this pull request
Feb 11, 2017
…ore (angular#3091) * closes angular#3086 * samples reworked to conform to our sample style, make more sense, and cover the points in prose. * copy edits to bring closer to Google docs standards.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3086
sample reworked to conform to our sample style, to make more sense, and cover the examples discussed
copy edits to bring closer to Google docs standards.