fix(orderBy): ensure correct ordering with arrays of objects and no predicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes #11866
Closes #11312
Closes #4282

Author: petebacondarwin

src/ng/filter/orderBy.js

@@ -205,7 +205,8 @@ function orderByFilter($parse) {
     function doComparison(v1, v2) {
       var result = 0;
       for (var index=0, length = predicates.length; index < length; ++index) {
-        result = result || compare(v1.predicateValues[index], v2.predicateValues[index]) * predicates[index].descending;
+        result = compare(v1.predicateValues[index], v2.predicateValues[index]) * predicates[index].descending;
+        if (result) break;
       }
       return result;
     }
@@ -247,14 +248,17 @@ function orderByFilter($parse) {
   }
 
   function objectValue(value, index) {
+    // If `valueOf` is a valid function use that
     if (typeof value.valueOf === 'function') {
       value = value.valueOf();
       if (isPrimitive(value)) return value;
     }
+    // If `toString` is a valid function and not the one from `Object.prototype` use that
     if (hasCustomToString(value)) {
       value = value.toString();
       if (isPrimitive(value)) return value;
     }
+    // We have a basic object so we use the position of the object in the collection
     return index;
   }