Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(orderBy): speed optimization #4282

Closed
wants to merge 1 commit into from
Closed

feat(orderBy): speed optimization #4282

wants to merge 1 commit into from

Conversation

agentcooper
Copy link
Contributor

Closes #4177.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@agentcooper
Copy link
Contributor Author

Name for the CLA: Artem Tyurin

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@agentcooper
Copy link
Contributor Author

Signed CLA: Artem Tyurin (artem.tyurin@gmail.com)

@IgorMinar
Copy link
Contributor

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@Narretz
Copy link
Contributor

Narretz commented Feb 19, 2014

Isn't this good to go (after a rebase)?

@agentcooper
Copy link
Contributor Author

hey, can this pull request get some attention maybe? :-)

@btford btford removed the gh: PR label Aug 20, 2014
@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from cad9560 to f294244 Compare October 2, 2014 22:08
@jeffbcross jeffbcross force-pushed the master branch 4 times, most recently from e8dc429 to e83fab9 Compare October 10, 2014 17:37
@Narretz Narretz self-assigned this Jun 9, 2015
@lgalfaso lgalfaso mentioned this pull request Jun 10, 2015
Merged
@lgalfaso
Copy link
Contributor

Closing this in favor of #12072

@lgalfaso lgalfaso closed this Jun 14, 2015
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jun 16, 2015
@petebacondarwin
fix(orderBy): ensure correct ordering with arrays of objects and no p…
5fb4e14 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes angular#11866
Closes angular#11312
Closes angular#4282
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jun 17, 2015
@petebacondarwin
fix(orderBy): ensure correct ordering with arrays of objects and no p…
055189c 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes angular#11866
Closes angular#11312
Closes angular#4282
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jun 18, 2015
@petebacondarwin
fix(orderBy): ensure correct ordering with arrays of objects and no p…
d317e1e 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes angular#11866
Closes angular#11312
Closes angular#4282
petebacondarwin added a commit to petebacondarwin/angular.js that referenced this pull request Jun 18, 2015
@petebacondarwin
fix(orderBy): ensure correct ordering with arrays of objects and no p…
afdd1df 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes angular#11866
Closes angular#11312
Closes angular#4282
petebacondarwin added a commit that referenced this pull request Jun 18, 2015
@petebacondarwin
fix(orderBy): ensure correct ordering with arrays of objects and no p…
48e1f56 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes #11866
Closes #11312
Closes #4282
netman92 pushed a commit to netman92/angular.js that referenced this pull request Aug 8, 2015
@petebacondarwin @netman92
fix(orderBy): ensure correct ordering with arrays of objects and no p…
0f41e5a 
…redicate

By refactoring to use a Schwartzian transform, we can ensure that objects
with no custom `toString` or `toValue` methods are just ordered using
their position in the original collection.

Closes angular#11866
Closes angular#11312
Closes angular#4282
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Narretz Narretz

Labels
cla: yes component: filters needs: review type: feature
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging this pull request may close these issues.

orderBy speed optimization
6 participants
@agentcooper @mary-poppins @IgorMinar @Narretz @lgalfaso @btford