Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit 3f365f5

Browse files
jmpalacioscaitp
authored andcommitted
docs(tutorial): match html from angular-phonecat in step 7 instructions
Place phoneId binding in a proper HTML node The code where the phoneId binding in the phone-detail.html template is first explained in step 7 of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test against the view (also introduced in step 7) fail. The test acquires the binding right from the view (by.binding('phoneId')), and apparently this operation fails when the binding is not a child of an HTML node, and therefore the entire test also fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and the test passes. The code on github for step 7 has it right, the binding is within the span tags, but in the documentation I'm patching here the span's are missing. ☆.。.:*・゜☆ MERCI ☆.。.:*・゜☆ Closes #7561
1 parent e9fad96 commit 3f365f5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/content/tutorial/step_07.ngdoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ We also added a placeholder template for the phone details view:
185185
__`app/partials/phone-detail.html`:__
186186

187187
```html
188-
TBD: detail view for {{phoneId}}
188+
TBD: detail view for <span>{{phoneId}}</span>
189189
```
190190

191191
Note how we are using the `phoneId` expression which will be defined in the `PhoneDetailCtrl` controller.

0 commit comments

Comments
 (0)