This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Place phoneId binding in a proper HTML node #7561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code where the phoneId binding in the phone-detail.html template is first explained in step 7 of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test against the view (also introduced in step 7) fail.
The test acquires the binding right from the view (by.binding('phoneId')), and apparently this operation fails when the binding is not a child of an HTML node, and therefore the entire test also fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and the test passes. The code on github for step 7 has it right, the binding is within the span tags, but in the documentation I'm patching here the span's are missing.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
The code contribution doc says that for small documentation fixes we don't need to worry about filing issues first. This is my first contribution so I didn't know about the extensive guidelines, and it's a very small fix so I hope it's alright to consider & merge as is. If not, I'll file it again in a while when I get the chance to correct the format. |
|
@jmpalacios it's all good =) |
|
Merged, thanks a bunch |
|
Great! Thanks for taking a look at it ;) |
RichardLitt
pushed a commit
to RichardLitt/angular.js
that referenced
this pull request
May 24, 2014
Place phoneId binding in a proper HTML node
The code where the phoneId binding in the phone-detail.html template is first explained in step 7
of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test
against the view (also introduced in step 7) fail.
The test acquires the binding right from the view (by.binding('phoneId')), and apparently this
operation fails when the binding is not a child of an HTML node, and therefore the entire test also
fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and
the test passes. The code on github for step 7 has it right, the binding is within the span tags,
but in the documentation I'm patching here the span's are missing.
☆.。.：*・゜☆ MERCI ☆.。.：*・゜☆
Closes angular#7561
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code where the phoneId binding in the phone-detail.html template is first explained in step 7 of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test against the view (also introduced in step 7) fail.
The test acquires the binding right from the view (by.binding('phoneId')), and apparently this operation fails when the binding is not a child of an HTML node, and therefore the entire test also fails. As soon as the binding is placed inside a tag pair, the binding is found and the test passes. The code on github for step 7 has it right, the binding is within the span tags, but in the documentation I'm patching here the span's are missing.