Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Commit ef1a9d2

Browse files
committedJan 8, 2015
chore(ngModelOptions): remove reference to angular.copy
Replaced a reference to `angular.copy` with just `copy`
1 parent 9c9c6b3 commit ef1a9d2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/ng/directive/ngModel.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1215,7 +1215,7 @@ var ngModelOptionsDirective = function() {
12151215
restrict: 'A',
12161216
controller: ['$scope', '$attrs', function($scope, $attrs) {
12171217
var that = this;
1218-
this.$options = angular.copy($scope.$eval($attrs.ngModelOptions));
1218+
this.$options = copy($scope.$eval($attrs.ngModelOptions));
12191219
// Allow adding/overriding bound events
12201220
if (this.$options.updateOn !== undefined) {
12211221
this.$options.updateOnDefault = false;

5 commit comments

Comments
 (5)

petebacondarwin commented on Jan 8, 2015

@petebacondarwin
Contributor

@lgalfaso - I think that strictly this should have been a style: or refact: commit. The chore: commits are about changes to the build process or related to the project files rather than code itself.

lgalfaso commented on Jan 8, 2015

@lgalfaso
ContributorAuthor

@petebacondarwin do you want me to amend the commit?

pkozlowski-opensource commented on Jan 8, 2015

@pkozlowski-opensource
Member

@lgalfaso i don't think it makes sense to ammend this coomit, lets just try to follow commit conentions more stricly in the future

lgalfaso commented on Jan 8, 2015

@lgalfaso
ContributorAuthor

ok

petebacondarwin commented on Jan 8, 2015

@petebacondarwin
Contributor

spot on!

This repository has been archived.